Fix ValueTrack with Resource is leaking #84942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
leak-res-track-cache
branch
3 times, most recently
from
e5e2ae3
to
b790b9f
Compare
akien-mga
approved these changes
Nov 15, 2023
TokageItLab
force-pushed
the
leak-res-track-cache
branch
from
b790b9f
to
f853d67
Compare
|
Thanks! |
nlupugla
reviewed
Nov 19, 2023
|
|
||
| ~AnimatedValuesBackup() { | ||
| for (KeyValue<NodePath, AnimationMixer::TrackCache *> &K : data) { | ||
| memdelete(K.value); |
There was a problem hiding this comment.
You might need a guard here to prevent a crash in a case where the TrackCache * is a nullpointer. Something like
if (K.value) {
memdelete(K.value);
}or
ERR_FAIL_NULL(K.value);
memdelete(K.value);
There was a problem hiding this comment.
This won't help if the pointer is freed (points to invalid, non-null, memory).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84483.
TrackCache must explicitly release references to the resource.