Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the compatibility renderer leaks Image objects when using the Editor #87196

Closed
Rubonnek opened this issue Jan 15, 2024 · 1 comment · Fixed by #87229
Closed

Enabling the compatibility renderer leaks Image objects when using the Editor #87196

Rubonnek opened this issue Jan 15, 2024 · 1 comment · Fixed by #87229

Comments

@Rubonnek
Copy link
Member

Rubonnek commented Jan 15, 2024

Tested versions

26b1fd0 - reproducible
4.2.1 - Not reproducible

System information

Godot v4.3.dev (e3b9f08ce) - Arch Linux #1 SMP PREEMPT_DYNAMIC Fri, 05 Jan 2024 16:20:41 +0000 - Tty - GLES3 (Compatibility) - AMD Radeon RX 6900 XT (radeonsi, navi21, LLVM 16.0.6, DRM 3.54, 6.6.10-arch1-1) () - AMD Ryzen 9 5950X 16-Core Processor (32 Threads)

Issue description

Enabling the compatibility renderer will leak Image objects. This issue does not happen with the Forward+ nor the Mobile rendering methods.

I think this issue was introduced within the last two months.

Steps to reproduce

Open the Editor against the MRP through the command line (i.e. for example godot -e --verbose if on path).

Close the editor after a few seconds and you should see a similar message:

WARNING: ObjectDB instances leaked at exit (run with --verbose for details).
     at: cleanup (core/object/object.cpp:2204)
Leaked instance: Image:-9170885200035390510 - Resource path: 
Leaked instance: Image:-9170880252233060709 - Resource path: 
Leaked instance: Image:-9170864309314457951 - Resource path: 
Leaked instance: Image:-9170863759558644050 - Resource path: 
Leaked instance: Image:-9170858811756319055 - Resource path: 
Leaked instance: Image:-9170858262000505166 - Resource path: 
Leaked instance: Image:-9170853863953994059 - Resource path: 
Leaked instance: Image:-9170853314198180170 - Resource path: 
Leaked instance: Image:-9170848366395855175 - Resource path: 
Leaked instance: Image:-9170847816640041286 - Resource path: 

Minimal reproduction project (MRP)

glow.zip - from the demo projects with the Compatibility renderer enabled by default.

@Rubonnek Rubonnek added this to the 4.3 milestone Jan 15, 2024
@Rubonnek
Copy link
Member Author

Rubonnek commented Jan 15, 2024

The last commit where this issue wasn't happening is 9444d29.

Issue introduced, or made apparent, by #86587.

CC @RandomShaper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment