Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inaccuracies in the report of leaked objects #87222

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix inaccuracies in the report of leaked objects #87222

merged 1 commit into from
Mar 6, 2024

Conversation

RandomShaper
Copy link
Member

Discovered while investigating #87196.

The reported object id was being reported wrongly, for a couple of reasons:

  1. The id was being computed wrongly. We could get the id from the object, but I've decided to keep the computation, only fixed.
  2. The id was printed as a signed integer, which was wrong for reference types, which have the MSB set.

@RandomShaper RandomShaper added bug topic:core cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 15, 2024
@RandomShaper RandomShaper added this to the 4.3 milestone Jan 15, 2024
@RandomShaper RandomShaper requested a review from a team as a code owner January 15, 2024 15:41
@RandomShaper RandomShaper changed the title gFix inaccuracies in the report of leaked objects Fix inaccuracies in the report of leaked objects Jan 15, 2024
@akien-mga akien-mga merged commit b85337b into godotengine:master Mar 6, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_obj_leaks_report branch March 6, 2024 12:36
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@RandomShaper @akien-mga