Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set resource_local_to_scene in surface_material_override causes error #88206

Open
KeiMuriKoe opened this issue Feb 11, 2024 · 7 comments · May be fixed by #88284
Open

set resource_local_to_scene in surface_material_override causes error #88206

KeiMuriKoe opened this issue Feb 11, 2024 · 7 comments · May be fixed by #88284

Comments

@KeiMuriKoe
Copy link

KeiMuriKoe commented Feb 11, 2024

Tested versions

4.2 stable

System information

Windows 10, Godot 4.2 Stable, Forward Mobile.

Issue description

image

Read Steps to reproduce.
servers/rendering/renderer_rd/storage_rd/material_storage.cpp:xxxx - Parameter "material" is null.

works only when set this to surface_material_override, the same with material - not causes error

Steps to reproduce

  1. create 2 scenes
  2. in 1st add meshinstance3D with any mesh
  3. set any type material to surface_material_override
  4. set in this material resource_local_to_scene to true
  5. save, and dragNdrop this scene with mesh to second. causes an error to output

Minimal reproduction project (MRP)

N/A

@RedMser

This comment was marked as outdated.

@KeiMuriKoe
Copy link
Author

I can not reproduce this on Godot v4.2.1 with the steps you provided. I tried both a Node3D root, and a MeshInstance3D root node for the first scene. In both cases, I used a BoxMesh with StandardMaterial3D.

Either way, there's a fix for local_to_scene coming in 4.3 (#71578) which will likely fix this issue as well. Just not sure why I don't get the error myself... Can you try reproducing it again on a 4.3 dev build?

ok,tried the same in 4.3 dev3.
To those errors that were, one warning has been added :
image

@KeiMuriKoe
Copy link
Author

let me send minimal project to reproduce:
4.3.zip

@KeiMuriKoe
Copy link
Author

image
drag n drop scene node_3d.tscn to node.tscn cause error, even if you didnt place it, just hold

@RedMser
Copy link
Contributor

RedMser commented Feb 11, 2024

Can confirm now, it only happens when doing drag&drop into the 3d view - it does not error when you drag into the scene tree. It also doesn't error when disabling resource_local_to_scene

@KeiMuriKoe
Copy link
Author

Can confirm now, it only happens when doing drag&drop into the 3d view - it does not error when you drag into the scene tree. It also doesn't error when disabling resource_local_to_scene

yeah, exactly, also doesn't error when add_child()

@Rindbee
Copy link
Contributor

Rindbee commented Feb 13, 2024

The warning is another issue, see #88125.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants