Set surface_override_material to RID() when the MeshInstance3D is freed
#88284
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is freed For resources with `resource_local_to_scene` enabled, a copy of the original resource instance is usually used. When the node instance is freed, the copied resouce instance may be freed soon. However, the relevant data in `RenderingServer` may not be synchronized in time, which may cause some error messages to be output. Set `surface_override_material` to `RID()` when the `MeshInstance3D` is freed.
Rindbee
force-pushed
the
reset-surface_override_material-to-empty-during-NOTIFICATION_PREDELETE-in-MeshInstance3D
branch
from
4d5d259
to
8ea0abe
Compare
Rindbee
changed the title
surface_override_material to RID() before the MeshInstance3D is freedsurface_override_material to RID() when the MeshInstance3D is freed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For resources with
resource_local_to_sceneenabled, a copy of the original resource instance is usually used. When the node instance is freed, the copied resouce instance may be freed soon. However, the relevant data inRenderingServermay not be synchronized in time, which may cause some error messages to be output.Fix #88206.