Added an experimental convert scripts option for godot3 export

[marcelofg55]

If enabled this option will convert gdscripts using regexp. So far it converts:

• _fixed_process( => _physics_process(
• _pos( => _position(
• KEY_RETURN => KEY_ENTER
• RawArray() => PoolByteArray()
• Vector2Array() => PoolVector2Array()
• .get_opacity() => .get_modulate().a
• .set_opacity(var) => .modulate.a = var
• .connect( => .connect_to_host( // (A HTTPClient object is detected first)
• ReferenceFrame => Control
• var.type == InputEvent.KEY => var.get_name() == "InputEventKey"
• var.type == InputEvent.MOUSE_MOTION => var.get_name() == "InputEventMouseMotion"
• var.type == InputEvent.MOUSE_BUTTON => var.get_name() == "InputEventMouseButton"
• var.type == InputEvent.JOYSTICK_MOTION => var.get_name() == "InputEventJoypadMotion"
• var.type == InputEvent.JOYSTICK_BUTTON => var.get_name() == "InputEventJoypadButton"
• is_move_and_slide_on_floor() => is_on_floor()
• is_move_and_slide_on_ceiling() => is_on_ceiling()
• is_move_and_slide_on_wall() => is_on_wall()

[Zylann]

set_opacity() conversion must use current color, not white. (If you assume that any set_opacity function is called on an object having a modulate)

[reduz]

Wow On Oct 7, 2017 10:52 PM, "Marc" <[email protected]> wrote: set_opacity() conversion must use current color, not white. (If you assume that any set_opacity function is called on an object having a modulate) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11863 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z23wiw1R_uxXQpVG1-ZldalaNQfweks5sqCrOgaJpZM4Pv1A4> .

[Zylann]

You could also rename "len" identifiers into "length", because "len" is now a reserved function keyword (if there is no other variable in the same scope named "length" already)

[Zylann]

@reduz what's going on? :D

[Zireael07]

Another candidate is FixedMaterial -> whatever the 3.0 equivalent is.

[Zylann]

Also AABB -> Rect3, Matrix -> Basis, ColorFrame -> ColorRect, Mesh -> ArrayMesh

[Zylann]

Maybe also .type == InputEvent.*** => is ***

[HummusSamurai]

When this is discussed for merge on IRC, I'd like to suggest that it be merged directly without waiting for all the changes to be added.

That way further additions to the conversion script can be contributed through subsequent PRs and help decentralise the effort.

[akien-mga]

For opacity, you can do changes in a non-destructive way (currently you're overriding potential modulate colors) with properties:

self.modulate.a = var

It would still overwrite the alpha channel of a potential modulate color, but we can assume that users were not using both opacity and modulate alpha at the same time.
Or we could do self.modulate.a *= var if we really want to be on the safe side :)

[marcelofg55]

@Zylann

You could also rename "len" identifiers into "length", because "len" is now a reserved function keyword (if there is no other variable in the same scope named "length" already)

I thought about that one too, but it probably is a tricky one since you have to avoid getting false positives as len is a pretty short and common word. But I'll give it a try later.

Also AABB -> Rect3, Matrix -> Basis, ColorFrame -> ColorRect, Mesh -> ArrayMesh

Are these direct conversions? I haven't used them myself in gdscript, so idk.

Maybe also .type == InputEvent.*** => is ***

Added :).

[marcelofg55]

@akien-mga Just fixed that modulate thing, thanks for the tip :).

[reduz]

this looks great, i think, if not implemented already, animations should also be properly fixed

[27thLiz]

This is not the recommended method for type checking.
Use var is InputEventKey instead.

[marcelofg55]

Just fixed it.

[akien-mga]

@marcelofg55 I'm doing some improvements to the script conversion, and wonder about this regexp. What's the point of [ ]* before \\.set_opacity\\(? Shouldn't it simply be "(.*)\\.set_opacity\\((.*)\\)(.*)"?

[marcelofg55]

I don't remember if there was a reason that I wrote that regexp that way, but it should work fine as you say as (.*)\\.set_opacity\\((.*)\\)(.*).