Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewportContainer passes input down to children viewports #15712

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Jan 14, 2018

ViewportContainer now listens for _input events and funnel them down to child viewports (unless Viewport.disable_input is set).

Fixes #15488.
Merger please have a look at #9950 (fixed, but latest docs should be updated to use ViewportContainer instead of Control) and #8419 (which still applies to 3.0 unless we agree it's by design, and I personally do).

You can test with: viewport_input_test.zip

@groud groud added the bug label Jan 14, 2018
@akien-mga akien-mga added this to the 3.0 milestone Jan 14, 2018

c->input(ev);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style issue here ;)

@Faless
Copy link
Collaborator Author

Faless commented Jan 14, 2018 via email

@Faless
Copy link
Collaborator Author

Faless commented Jan 14, 2018

done

@reduz
Copy link
Member

reduz commented Jan 14, 2018

Seems perfect! (for when travis finishes)

@akien-mga akien-mga merged commit b68a972 into godotengine:master Jan 15, 2018
@Faless Faless deleted the viewport_input branch September 13, 2018 01:07
@Faless Faless restored the viewport_input branch September 13, 2018 01:07
@Faless Faless deleted the viewport_input branch September 13, 2018 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewport does not handle input even it "Disable Input" is off
4 participants