2 to 3 converter: More fixes to the property renames #17560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some bugs with missing or incorrect renames in the process.
- Fixed properties with different renames based on node type:
* Convert Joint2D's "collision/exclude_nodes" to "disable_collision"
* Convert TextureProgress' "mode" to "fill_mode"
* Convert Sprite and Sprite3D's "region" to "region_enabled"
- Fixed swapping "Fill" and "Expand" in size_flags
- Handle converting [self_]opacity to [self_]modulate.a, including in animations
- Fixed signals:
* Add a bunch of missed signal renames
* Properly convert AnimationPlayer and AnimatedSprite's "finished" to
"animation_finished"
- Reduce diff in signal connections for tscn
- Script converter:
* Convert _input_event( to _gui_input(
* Convert self_opacity to self_modulate.a
* Convert ReferenceFrame to ReferenceRect
* Add missing Pool*Array conversions
akien-mga
force-pushed
the
2to3-exporter
branch
from
dcf1f4c
to
8fd6543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.