log to console if falling back to dummy audio driver #21400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Aug 25, 2018
main/main.cpp
Outdated
| @@ -917,6 +917,10 @@ Error Main::setup(const char *execpath, int argc, char *argv[], bool p_second_ph | |||
| audio_driver = GLOBAL_DEF_RST("audio/driver", OS::get_singleton()->get_audio_driver_name(0)); | |||
| } | |||
|
|
|||
| if (audio_driver == "Dummy") { | |||
| print_line("Failed to attach audio driver. Falling back to dummy driver."); | |||
There was a problem hiding this comment.
The problem is that it will print that all the time with the server platform, where it's using the Dummy driver on purpose, not because other drivers failed.
There was a problem hiding this comment.
I'd add this on the AudioServer code rather than on the Main code. Something like this should do the trick: https://gist.github.com/marcelofg55/a11c015d758a4b3372a8375c068c1b01
|
CC @marcelofg55 |
|
Could you squash the commits? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dummy audio driver now seems to serve as fallback, I think it should be visible when other audio drivers fail. This diff logs it with
print_line(); main alternative would bealert()but that seemed too intrusive for my taste.