Fix filesystem dock which allow to exist folders with the same name - e.g. AAA and aaa on Windows

[dualtagh]

Fixes #22475

The script editor doesn't actually create a new folder called "AAA", but it does add it to the FileSystem tree. Rescanning when a new script is added to refresh

[akien-mga]

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.

Note: If it's merged after 3.1-stable is released, this change may be considered for cherry-picking into a later 3.1.x release.

[akien-mga]

This needs a rebase to solve the merge conflicts and squash the two commits together, see PR workflow.

Otherwise I guess the changes seem safe enough.

[akien-mga]

Moving to 4.0 milestone as we're now in release freeze for Godot 3.2, and this bugfix is not critical to merge now. It may still be cherry-picked for the 3.2.x branch once merged in master.

[Anutrix]

@dualtagh Requesting rebase.

[dualtagh]

@Anutrix Done 👍

[Anutrix]

clang-format is failing.
Have a look at #33027.

[KoBeWi]

Seems like the PR is broken. These changes are irrelevant. Some rebase mistake?

[KoBeWi]

@dualtagh Sorry I was misled by the title, but after looking into the issue this is actually correct. Although you don't need to create new method, you can connect directly to _rescan() if you use unbind():

make_script_dialog->connect("script_created", callable_mp(this, &FileSystemDock::_rescan).unbind(1));

However not only scripts have this issue. Same happens with resources and scenes. You could add _rescan() to _make_scene_confirm() and _resource_created() methods to prevent that.

Sorry again, if you make the changes, the PR could be finally merged.

[YuriSizov]

I've reimplemented the PR as I think the original author doesn't participate anymore. I've still credited them for the initial effort, so thanks for that! 🙂