Enabling ipv6 in libwebsockets #26189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Feb 23, 2019
| @@ -78,6 +78,7 @@ | |||
|
|
|||
| /* Build with support for ipv6 */ | |||
| /* #undef LWS_WITH_IPV6 */ | |||
| #define LWS_WITH_IPV6 | |||
There was a problem hiding this comment.
Please add // -- GODOT start -- and // -- GODOT end -- comments around it, so that we know that we changed this on purpose. Otherwise it will likely be reset next time with sync with upstream's default config.
Faless
approved these changes
Feb 23, 2019
There was a problem hiding this comment.
Good job, thanks!
P.S.: I don't think we need the -- GODOT ADDITION -- line, that's an auto-generated file and that def/undef depends on a cmake flag. and on which platform you called cmake.
I had the:
/* GODOT ADDITION */ line on top because we where using DEBUG_ENABLED which is only defined in godot.
Faless
approved these changes
Feb 23, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile libwebsockets with ipv6 support, without it, websockets are not working in ipv6 networks, and the "localhost" keyword is not working in a big number of Operating Systems with predefined ipv6 resolutions of it.