Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libwebsockets to 3.1, fix IPv6 issues #26688

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Update libwebsockets to 3.1, fix IPv6 issues #26688

merged 3 commits into from
Mar 6, 2019

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Mar 6, 2019

Huge diff, basically just a library update with some extras:

  • Add fix to libwebsocket to disable V6ONLY on IPv6 sockets (was causing issues on Windows, fixes WebSocketClient failed to connect to any server other than localhost on Windows #26517 )
  • Disable WebSocket IPv6 support on OpenBSD (dual stacking doesn't work there, forcing IPv4 only).
    NOTE: hopefully, in 3.2 I'll be able to migrate to wslay and use our NetSocket interface supporting both IPv4 and IPv6 on OpenBSD too (still without dual-stacking ofc).

@Faless
Update libwebsockets to 3.1 (plus UWP patch)
90210c4
@Faless
Add fix to libwebsocket to disable V6ONLY.
e3ddf12 
This was enabled by default on some systems (e.g. Windows).
@Faless
Disable WebSocket IPv6 support on OpenBSD.
6d64a54 
OpenBSD does not support dual stacking, disabling IPv6 for now.
Will possibly come back if/when we get websocket running using our own
NetSocket class.
@Faless Faless requested review from akien-mga and a team as code owners March 6, 2019 08:43
@Faless Faless added this to the 3.1 milestone Mar 6, 2019
@Faless Faless mentioned this pull request Mar 6, 2019
Closed
@akien-mga
Copy link
Member

After this change, do we still support distros building against their system-packaged libwebsockets?

@Faless
Copy link
Collaborator Author

Faless commented Mar 6, 2019

After this change, do we still support distros building against their system-packaged libwebsockets?

We should, but I haven't actually tested it. Linux distros usually have V6ONLY OFF by default, and, when that isn't the case, I assume whoever packages the lib will notice that it's impossible to connect to anything IPv4 because it doesn't call the right setsockopt.
I mean, the library can be compiled with IPv6 OR IPv4, not both so there isn't much we can do there 👎 .
I'll try to compile with distro libwebsockets and see, but again, YMMV based on distro/network settings/package maintainer.

@akien-mga akien-mga merged commit 97774f6 into godotengine:master Mar 6, 2019
@akien-mga
Copy link
Member

Thanks!

@Faless Faless mentioned this pull request Apr 1, 2019
Closed
@ASavchenkov ASavchenkov mentioned this pull request Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

Assignees
No one assigned
Labels
bug topic:network topic:thirdparty
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

WebSocketClient failed to connect to any server other than localhost on Windows
2 participants
@Faless @akien-mga