Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deselect hidden nodes on filter #29200

Merged
merged 1 commit into from
May 27, 2019
Merged

Deselect hidden nodes on filter #29200

merged 1 commit into from
May 27, 2019

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 26, 2019

Fixes #25794

This is similar to #27659, but instead of awkward NULLing the editor_selection, it deselects nodes that become invisible on filter.

@akien-mga
Copy link
Member

This is similar to #27659, but instead of awkward NULLing the editor_selection, it deselects nodes that become invisible on filter.

Should the fix made in #27659 be improved in the same way?

@akien-mga akien-mga added this to the 3.2 milestone May 27, 2019
@KoBeWi
Copy link
Member Author

KoBeWi commented May 27, 2019

This PR is actually meant to supersede the other one.

@akien-mga
Copy link
Member

Oh right, I thought that other PR had been merged already.

@akien-mga akien-mga merged commit 6f49fc2 into godotengine:master May 27, 2019
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request May 27, 2019
Closed
@KoBeWi KoBeWi deleted the filter_select branch May 27, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Selected Node in Editors Node Tree isn't deselected when filtered
3 participants
@KoBeWi @akien-mga @YeldhamDev