Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build rule file for proper MSVC release build #34

Merged
merged 1 commit into from
Feb 13, 2014

Conversation

marynate
Copy link
Contributor

  • Add /ENTRY:mainCRTStartup linker flag for MSVC release build
  • Move /DEBUG linker flag to debug build only

@reduz
Copy link
Member

reduz commented Feb 13, 2014

I'm not sure if I understand this. what does /ENTRY:mainCRTStartup do?

@godotengine
Copy link
Collaborator

ah I see, with this I can delete WinMain on godot_windows.cpp ?

On Wed, Feb 12, 2014 at 11:17 PM, reduz [email protected] wrote:

I'm not sure if I understand this. what does /ENTRY:mainCRTStartup do?

Reply to this email directly or view it on GitHubhttps://github.com//pull/34#issuecomment-34941834
.

OkamStudio

@punto-
Copy link
Contributor

punto- commented Feb 13, 2014

Is that to get rid of the WinMain entry point? is there any advantage to
using it? (other than deleting WinMain wich already very welcome)

On Wed, Feb 12, 2014 at 11:17 PM, reduz [email protected] wrote:

I'm not sure if I understand this. what does /ENTRY:mainCRTStartup do?

Reply to this email directly or view it on GitHubhttps://github.com//pull/34#issuecomment-34941834
.

@marynate
Copy link
Contributor Author

Yes, it get rid of WinMain, so one single main entry point to be maintained as debug build while show no console window.
But more important is that without "/ENTRY:mainCRTStartup" flag, MSVC release build won't run properly ( eg, godot.exe -path path_to_game will not startup the game). It might be the bug in windows argument parsing.

godotengine pushed a commit that referenced this pull request Feb 13, 2014
Fixed build rule file for proper MSVC release build
@godotengine godotengine merged commit ca60bae into godotengine:master Feb 13, 2014
@draxdeveloper draxdeveloper mentioned this pull request Aug 31, 2015
lawnjelly added a commit to lawnjelly/godot that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants