mistake #3545
Closed
mistake #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add FA (Persian) Locale
Add RTL text support for all section of godot engine. for use rtl text in godot engine import a font that contains arabic glyphs and use that for editor font or gui font. (godot default fonts not contains arabic glyphs)
Update from original
Create new bidi class and use that in text rendering. and fix some bugs.
fixe earab (fatha,kasra,shada,...) positions and nsm type in start of paragraph problem. add some comment for license.
RTL Support
|
Whats wrong? Seemed like a patch to add bidi without deps
|
|
Don't mind it, it's the third time this user makes the same weird PR from an "unknown repository". The actual commits come from #2297 by another contributor, who eventually closed it as it used copylefted *bidi implementations IIUC. Then yet another contributor implemented RTL support in #2886, which is still open but has for now merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.