Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added game module compilation argument #36883

Closed
wants to merge 1 commit into from

Conversation

AndreaCatania
Copy link
Contributor

This is the integration of this feature proposal godotengine/godot-proposals#565

I've already integrated it to see if it could be integrated in a clean way before propose it.

To keep things in order, please discuss here only technical things and improvements of this code, for any other thing please use the feature proposal page.

@Xrayez
Copy link
Contributor

Xrayez commented Mar 7, 2020

Does this implementation work with both absolute and relative paths supplied to game_module argument? I wasn't sure whether Scons could do that, I assumed that everything needs a relative path.

@Xrayez
Copy link
Contributor

Xrayez commented Mar 7, 2020

I just tested this PR, works flawlessly for me.

If you plug in some existing C++ module, the only changes you need to do is defining:

void preregister_types();
void register_types();
void unregister_types();

And remove module-specific methods like register_your_specific_module_types() and family. 🙂

Do you think it would be possible to infer module name from game_module path to avoid this?

I'm still not sure whether this is intended to work as a module or as a general-purpose C++ package, so to speak, see my comment at: godotengine/godot-proposals#565 (comment).

@AndreaCatania
Copy link
Contributor Author

Do you think it would be possible to infer module name from game_module path to avoid this?

This could be possible, but my initial idea were this:

A general-purpose C++ package, so to speak

Were you can plug anything you want, if you want how you desire.

@AndreaCatania
Copy link
Contributor Author

AndreaCatania commented Mar 9, 2020

I'm closing this in favour of this: #36922

@AndreaCatania AndreaCatania deleted the game_module branch March 9, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants