-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use Github Actions instead Travis CI #38433
Conversation
7e36e47
to
91a3ad0
Compare
Great work 🙂 In March, I started working on a WIP branch to migrate Godot's CI to GitHub Actions, but this PR seems more complete so far.
This is not critical for now. It can be added in a future PR.
It can be run on the same branch, just with a different schedule. IIRC, the job definition can also be located in the same file.
Artifacts expire after 90 days (unless you set a lower duration yourself). From what I've seen in GitHub's Billing settings, you can use up to 2 GB of storage per account/organization with a free account. In our case, we should probably make the storage duration short to avoid running out of space. If we need it, we could contact GitHub support to ask for more storage space. |
Thanks for doing this, really appreciated it, I created a branch with caching and the windows build just to remove appveyor it was annoying me. Added the caching and some python versioning tools which make it more generic and cross-platform to setup python :) which is really cool actually. |
Seems unrelated to #40131? Was that a typo? Also: something, something, monopolies... |
That was a typo yes. |
This is only Proof of Concept which I'll probably never finish, so if you want to do this better feel free to create your own PR based on this.
For the time being, I see this advantages of Github over Travis
This PR isn't complete and this things should be fixed:
There is commented Cppcheck step because it took over 1h, and this is too much for checking.
I suggest move this to new file and execute it on different branch to execute it e.g. once per week.
Also should be also added support to Sonarcloud and maybe even Coverity Scan(dropped in past) which can take as base this gitlab-ci.yml file - https://gitlab.com/qarmin/godot/-/blob/master/.gitlab-ci.yml
Example of Sonarcloud project - https://sonarcloud.io/dashboard?id=qarmin_godot
Here is example of simple and good github actions integrations in Assimp - https://github.com/assimp/assimp/actions
Example outputs/jobs - https://github.com/qarmin/godot/actions/runs/94442494, https://github.com/qarmin/godot/actions