Check if screen space reflection has passed far clip #38954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the issue affect only GLES3 or also the GLES2 backend? |
|
I don't think screen space reflections are supported in GLES2. They don't show after switching renderers and they aren't listed in the Environment options. |
|
Ah you're right :) |
lawnjelly
reviewed
Jun 4, 2020
Before "accepting" the reflection, check if it's within our view (prevent tracing environment and creating artifacts).
reduz
approved these changes
Oct 18, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors (ha) similar check in master/4.0 branch. Before "accepting" the reflection, check if it's within our view (prevents tracing environment and creating artifacts).
Closes #38953