Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process_mode property to InterpolatedCamera #41402

Merged

Conversation

saneery
Copy link

@saneery saneery commented Aug 20, 2020

move_and_slide in _physics_process + InterpolatedCamera == stutter
ezgif-5-9e777cb7f7fd

Like this #24806 but for InterpolatedCamera
This allows the user to choose if the camera should update in _process or _physics_process.

@saneery saneery force-pushed the interpolated-camera-process-mode branch from a384e28 to 4aaa21f Compare August 20, 2020 15:56
@KoBeWi KoBeWi added this to the 3.2 milestone Aug 20, 2020
@saneery saneery force-pushed the interpolated-camera-process-mode branch from 4aaa21f to b632894 Compare August 20, 2020 15:57
@saneery saneery force-pushed the interpolated-camera-process-mode branch from 28ec650 to 50bcbb9 Compare October 2, 2020 13:55
@Calinou
Copy link
Member

Calinou commented Mar 7, 2021

Note that integrating lawnjelly's smoothing-addon is a better way to combat stuttering compared to updating the camera position in the physics process loop.

@saneery saneery requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@aaronfranke aaronfranke modified the milestones: 3.2, 3.3 Mar 16, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@Chaosus Chaosus modified the milestones: 3.4, 3.5 Nov 8, 2021
@akien-mga akien-mga force-pushed the interpolated-camera-process-mode branch from 50bcbb9 to cb94797 Compare July 2, 2022 23:47
@saneery saneery requested a review from a team as a code owner July 2, 2022 23:47
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this. I think this makes sense, and this is consistent with ClippedCamera and Camera2D (Camera itself doesn't have it, but doesn't seem to do any processing).

I force pushed a rebase to fix some style issues, add documentation, and properly initialize the process_mode property (to idle, to preserve compatibility with 3.4).

@akien-mga akien-mga merged commit 567083b into godotengine:3.x Jul 2, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants