-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement manual particle emission and particle sub emitters. #41810
Conversation
Shader compilation fails on MoltenVK:
|
5dfcc00
to
c7636db
Compare
@bruvzg I thought empty arrays were allowed nowadays in C++, being 2020 but seems its not the case, so had to change the size to 1. |
It's shader build error not engine build, zero size arrays do trigger warning but it's still building whiteout |
Indeed:
|
c7636db
to
d0bddf5
Compare
ok lets hope it builds now |
It builds with |
vec4 custom; | ||
}; | ||
|
||
layout(set = 1, binding = 2, std430) restrict volatile coherent buffer SourceEmission { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing volatile
and coherent
qualifiers from here fixes shader compilation error, not sure what consequences this has. It works with this change.GPUParticles3D
seems to be broken regardless of this change.
layout(set = 1, binding = 2, std430) restrict volatile coherent buffer SourceEmission { | |
layout(set = 1, binding = 2, std430) restrict buffer SourceEmission { |
Uses compute shader atomics to implement manual particle emission and sub emitters.