AnimationStateMachinePlayback: Added Missing Method Bindings #42188
Conversation
There was a problem hiding this comment.
Seems useful. It would be nice to update the documentation with the two new methods here:
https://github.com/godotengine/godot/blob/master/doc/classes/AnimationNodeStateMachinePlayback.xml
pouleyKetchoupp
added
the
cherrypick:3.x
|
Indeed if we add methods to the public API, they need documentation. |
|
@akien-mga Sure, just wanted to propose the changes first before writing documentation. I'll take the time to do that this weekend. |
Eoin-ONeill-Yokai
force-pushed
the
animationstateplayback/missing_binds
branch
from
8348af0
to
6045aa8
Compare
Eoin-ONeill-Yokai
requested review from
akien-mga
and removed request for
a team
|
@akien-mga Sorry for the delay, I've been rather busy. I've added the documentation and corrected the method name in the bindings for GDScript. I've also rebased onto master. |
|
Could you squash the three commits into one? Then it should be good to merge. |
…` and `get_current_length`. This allows the user to query the AnimationNodeStateMachinePlayback's current play position and total length of current animation state. These methods are currently used in the editor plugin, but can also be useful for querying general playback state information. Added documentation for AnimationNodeStateMachinePlayback's `get_current_play_position`
Eoin-ONeill-Yokai
force-pushed
the
animationstateplayback/missing_binds
branch
from
6045aa8
to
674fb52
Compare
|
@akien-mga It's all merged down to a single commit now. Thanks :) |
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Added missing bindings to
get_current_play_posandget_current_length.This allows the user to query the AnimationNodeStateMachinePlayback's current play position and total length of current state. These methods are currently used in the C++ editor plugin, but can also be useful for querying general playback state information for gameplay purposes. It can also be useful for driving state machine playback via script.