Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using a comma as decimal separator in EditorSpinSlider #42376

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 27, 2020

Replacing the comma with a dot prevents using functions like pow(), but using functions in EditorSpinSlider is a barely known (and barely used) feature. Instead, we'd rather support German/French keyboard layouts out of the box.

This closes godotengine/godot-proposals#1576.

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Sep 27, 2020
@Calinou Calinou added this to the 4.0 milestone Sep 27, 2020
@akien-mga
Copy link
Member

Alright, I give in :) (For the reference, see #24532.)

@akien-mga akien-mga merged commit 82d1265 into godotengine:master Sep 28, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 29, 2020
@Calinou Calinou deleted the editorspinslider-comma-decimal branch September 30, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow comma as decimal separator in the Inspector
2 participants