Change render octree balance default #42927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another bug in the octree has been discovered which can cause flickering in rare circumstances : godotengine#42895 For safety until this is fixed properly this PR reverts the default state of the octree to match the old behaviour, which doesn't appear exhibit the bug (or at least not as readily).
akien-mga
approved these changes
Oct 21, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bug in the octree has been discovered which can cause flickering in rare circumstances : #42895
For safety until this is fixed properly this PR reverts the default settings for the octree to match the old behaviour, which doesn't appear exhibit the bug (or at least not as readily). These can still be overridden via the project setting.
As discussed with @akien-mga
This is just a temporary fix for the beta, it isn't a massive concern as the bug seems rare, and indeed this PR does swap one bug for another (the runaway depth recursion susceptibility of the old octree #38142, when there is no minimum number of elements required before octant splitting). But probably worth doing as a safety measure if I haven't identified the bug source in time.