CSGShape use_collision functionality improvement, plus parent and visibility update fixes #43322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…ibility update fixes
|
Closing in favor of #40814 due to performance and simplicity. Collisions should be handled by other nodes if a specific shape is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is identical to #40814, but with changes to
use_collisiondetailed in #43251 (comment).use_collisionis now enabled for all child shapes and can be used to toggle collision on an individual basis.CSGCombiners#43251.CSGShapeupdates when changing the parent's visibility or hierarchy. Fixes Stuttering when togglingCSGShapevisibility or changing its parent #40931.CSGShape._update_shape()doesn't work properly when invisible or outside the scene tree #41093.parenttoparent_shape.CSGShape3D::_notification.Test projects:
40814 Test Suite - Visibility.zip
40814 Test Suite - Scene Tree.zip
40814 Test Suite - Collision.zip