Document the lack of localization remapping support in VideoPlayer (reverted) #43920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
|
Is this intended behaviour or a technical limitation? I don't see why we should document this bug instead of fixing it. |
I don't know how difficult it would be to solve this. Not to mention that video playback is in a pretty bad state anyway, so the goal is to move it to GDNative-based add-ons in 4.x. Either way, documenting known bugs is often considered far better than not doing so. If you really need remapping for videos, I believe you could do it manually by loading a different video path based on the current locale. |
akien-mga
approved these changes
Dec 10, 2020
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #43917.