Possible fix for crash on import of a GLB file #44020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash where the cross product's length is smaller than the epsilon value
|
This pull request should be opened against the Also, changes to third-party libraries should be added to a Make sure to submit this pull request upstream as well – we try to be cooperative with upstream whenever possible 🙂 |
|
This needs to be a .patch and should come from master first. |
|
Superseded by #44023. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash during import of a particular GLB file, where the cross product's length is smaller than the epsilon value, and the vector is considered zero length causing an assert.
More details on the crash available in the issue: #44017