Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak log file names for consistency between Mono and non-Mono logs #44148

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 6, 2020

  • Avoid spaces in Mono log file names.
  • Use a .log extension for Mono logs, just like non-Mono logs.
  • Use periods to separate hours/minutes/seconds for non-Mono logs.

#21895 made me realize there was a dedicated Mono logging system, so I took the time to make this more consistent. 😛

- Avoid spaces in Mono log file names.
- Use a `.log` extension for Mono logs, just like non-Mono logs.
- Use periods to separate hours/minutes/seconds for non-Mono logs.
@Calinou Calinou requested a review from neikeq as a code owner December 6, 2020 19:17
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:core labels Dec 6, 2020
@Calinou Calinou added this to the 4.0 milestone Dec 6, 2020
@akien-mga akien-mga merged commit a834055 into godotengine:master Dec 8, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 9, 2020
@Calinou Calinou deleted the tweak-log-file-names branch March 31, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants