Refactored EditorHistory, removed unused code, added documentation. #44222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricEzaM
force-pushed
the
PR/editor-history-refactor-and-doco
branch
2 times, most recently
from
b47a5f3
to
db5c67a
Compare
EricEzaM
force-pushed
the
PR/editor-history-refactor-and-doco
branch
from
db5c67a
to
588f9f0
Compare
EricEzaM
commented
Dec 9, 2020
Comment on lines
-61
to
-67
| if (j <= history[i].level) { | ||
| //before or equal level, complete fail | ||
| fail = true; | ||
| } else { | ||
| //after level, clip | ||
| history.write[i].path.resize(j); | ||
| } |
There was a problem hiding this comment.
We already established that level is the last item in the path. Thus the first if will always be true.
|
Superseded by #58395. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to document and refactor a bit of the editor so it is easier for people to work with.
Starting small, with the EditorHistory.
HISTORY_MAXenum was never usedEditorHistory::PropertyDatastruct was never usedadd_objectmethod variants withp_level_changewere never used, andlevelproperty never changes.levelproperty is essentially just a convenience forhistory[current].path.size() - 1(i.e. last item in path)add_objectmethod variants were so rarely used, it made more sense to make the underlying_add_objectpublic and just give it default parameters. This required only one external change, whereadd_object_inspector_onlywas used in EditorNode.