Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a project setting to enable stdout flushing in release builds #44393

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 15, 2020

This can be used in server builds for journalctl compatibility.

This closes godotengine/godot-proposals#1912.

@Calinou Calinou force-pushed the add-stdout-flush-project-setting branch from de8b591 to 62124c9 Compare December 15, 2020 13:47
@Calinou Calinou requested a review from a team as a code owner December 15, 2020 13:47
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:core labels Dec 15, 2020
@Calinou Calinou added this to the 4.0 milestone Dec 15, 2020
@Calinou Calinou force-pushed the add-stdout-flush-project-setting branch 2 times, most recently from b9954ee to 68b3569 Compare December 15, 2020 13:49
This can be used in server builds for journalctl compatibility.
@Calinou Calinou force-pushed the add-stdout-flush-project-setting branch from 68b3569 to 341b9cf Compare December 15, 2020 15:41
@akien-mga akien-mga merged commit f3dccf5 into godotengine:master Dec 17, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

akien-mga commented Dec 29, 2020

Cherry-picked for 3.2.4.

@akien-mga
Copy link
Member

akien-mga commented Jan 5, 2021

Cherry-picked for 3.2.4.

Reverted before 3.2.4 beta 5 due to #44850.

It's still merged in master which is still affected by #44850.

@Calinou
Copy link
Member Author

Calinou commented Feb 13, 2021

Now that we've found a fix in master, can this be cherry-picked to 3.2 again with #45853 applied on top? Thanks in advance 🙂

@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 14, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4. (Together with #45853 squashed in the cherry-pick.)

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 14, 2021
@PizzaConsole
Copy link

PizzaConsole commented Feb 23, 2021

I am still getting this error on ubuntu 20.04

Godot Engine v3.2.4.rc3.mono.official - https://godotengine.org

ERROR: get_language_code: Condition "p_locale.length() < 2" is true. Returned: p_locale
   At: core/translation.cpp:945.
ERROR: set_locale: Unsupported locale 'C', falling back to 'en'.
   At: core/translation.cpp:969.

However, it does not exit my application service, so that fixes my core problem. it does give me this feedback-

server.service - My application service
     Loaded: loaded (/etc/systemd/system/server.service; enabled; vendor preset: enabled)
     Active: active (running) since Tue 2021-02-23 19:50:22 UTC; 46s ago
   Main PID: 1790 (godot-server)
      Tasks: 6 (limit: 2344)
     Memory: 32.1M
At: core/os/dir_access.cpp:185.
ERROR: get_language_code: Condition "p_locale.length() < 2" is true. Returned: p_locale
At: core/translation.cpp:945.
ERROR: set_locale: Unsupported locale 'C', falling back to 'en'.
At: core/translation.cpp:969.
ERROR: make_dir_recursive: Method failed. Returning: err
At: core/os/dir_access.cpp:185.
ERROR: _try_create_logs_dir: Condition "logs_mkdir_err != OK" is true. Returned: false
At: modules/mono/mono_gd/gd_mono_log.cpp:109.
Mono: No log file, using default log handler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a project setting to flush standard output on every printed line
3 participants