-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow input echo when changing ui focus #44456
allow input echo when changing ui focus #44456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The input->is_action_pressed("ui_focus_next")
part is no longer necessary, as it's already checked in the event (or at least I don't see any difference after removing it).
Also this needs rebase.
Is it looks ok now? |
@univeous FYI, the email used to sign your commit (see header of https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/44456.patch ) doesn't seem to be linked to your GitHub account. That's not a problem for Git nor for us, but if you want to get full attribution for this commit, you can add this email as secondary email in your GitHub settings. |
not noticed before. Added. thank you! |
Thanks! |
Cherry-picked for 3.4. |
It will allow us to change UI focus continuously by holding navigation key.
before:
after:
It's a more common UI pattern. In Godot editor itself it works like the latter.
Discussion