Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the editor CheckButton "pressed" appearance to be more recognizable #44556

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 20, 2020

The blue accent color is now used, which matches the default editor accent color. The dot contained within the slider is also now white to be visible on any background.

It doesn't change to match the currently configured accent color automatically, but doing so would require modifying the CheckButton class a lot for little benefit.

This closes godotengine/godot-proposals#2002.

Preview

Dark

2020-12-20_22 20 23

2020-12-20_22 20 14

Light

2020-12-20_22 23 13

2020-12-20_22 23 23

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Dec 20, 2020
@Calinou Calinou added this to the 4.0 milestone Dec 20, 2020
@Calinou Calinou force-pushed the improve-editor-checkbutton-apperance branch from 621a735 to 0658497 Compare December 20, 2020 21:31
The blue accent color is now used, which matches the default editor
accent color.

It doesn't change to match the currently configured accent color
automatically, but doing so would require modifying the CheckButton
class a lot for little benefit.
@akien-mga akien-mga merged commit 59b3b9f into godotengine:master Dec 20, 2020
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou changed the title Tweak the editor CheckButton "presed" appearance to be more recognizable Tweak the editor CheckButton "pressed" appearance to be more recognizable Dec 25, 2020
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 29, 2020
@Calinou Calinou deleted the improve-editor-checkbutton-apperance branch March 31, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak the editor CheckButton appearance to clarify what's the "on" state
2 participants