Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Add AspectRatioContainer class #45129

Merged
merged 1 commit into from
Jan 12, 2021
Merged

[3.x] Add AspectRatioContainer class #45129

merged 1 commit into from
Jan 12, 2021

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Jan 12, 2021

3.2 version of #43807.

@Xrayez Xrayez requested a review from a team as a code owner January 12, 2021 14:13
@YeldhamDev YeldhamDev added this to the 3.2 milestone Jan 12, 2021
@Xrayez
Copy link
Contributor Author

Xrayez commented Jan 12, 2021

CI fails https://github.com/godotengine/godot/pull/45129/checks?check_run_id=1688580627#step:10:955, not sure how to fix because those come from GDCLASS macro expansion...

@bruvzg
Copy link
Member

bruvzg commented Jan 12, 2021

not sure how to fix because those come from GDCLASS macro expansion...

Remove override from virtual Size2 get_minimum_size() const override; (aspect_ratio_container.h line 42), it won't complain when there are no overrides at all.

@UgisProductMadness
Add AspectRatioContainer class
acd9abe 
Backported from ba68383.

Co-authored-by: Ugis Brekis <[email protected]>
@akien-mga akien-mga merged commit 8f265e8 into godotengine:3.2 Jan 12, 2021
@akien-mga
Copy link
Member

Thanks!

@Xrayez Xrayez deleted the aspect-ratio-container-3.2 branch January 12, 2021 14:51
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
@aaronfranke aaronfranke changed the title Add AspectRatioContainer class [3.x] Add AspectRatioContainer class Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
feature proposal topic:gui
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Xrayez @bruvzg @akien-mga @YeldhamDev