Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Asset Library API URLs to the Editor Settings #45202

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

aaronfranke
Copy link
Member

This PR was inspired by #31613. It allows you to set your own Asset Library URLs. Here's what the default looks like:

Screenshot from 2021-01-15 01-32-01

These options show up in the (already existing) "Site:" section in the AssetLib main screen.

@aaronfranke aaronfranke added enhancement topic:editor topic:plugin cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jan 15, 2021
@aaronfranke aaronfranke added this to the 4.0 milestone Jan 15, 2021
@akien-mga akien-mga merged commit 7601ccb into godotengine:master Jan 26, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 26, 2021
@aaronfranke aaronfranke deleted the assetlib-url branch January 26, 2021 17:17
@menip
Copy link
Contributor

menip commented Mar 11, 2021

The repository selection metadata needs to be updated every time the settings for asset_library/available_urls changes, otherwise you have to restart editor after you add a repository or update existing one.

This is still an issue as of 85cb3c0

@Calinou
Copy link
Member

Calinou commented Jun 25, 2021

Should localhost still be listed by default? It won't work unless the user is hosting an asset library locally, which is very unlikely.

Edit: Fixed by #50768.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants