Use real_t in physics code #45519
Merged
Use real_t in physics code #45519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaCatania
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
The changes look good.
Just a couple things I'm wondering:
- There are still references to PACKED_FLOAT32_ARRAY in ConvexPolygonShape2DSW and ConcavePolygonShape2DSW data, I guess they can be changed as well (it's just error messages it seems).
- It might be outside of this PR's scope, but float is still used extensively in scene nodes, including physics 2D and 3D. Should it be changed too to make sure things stay consistent when using double precision?
|
@pouleyKetchoupp I will likely copy more stuff out of #21922 later to more PRs if it's something that has a good chance of being merged. |
aaronfranke
force-pushed
the
physics-real_t
branch
from
e55139f
to
cb9fc11
Compare
Xrayez
approved these changes
Jan 29, 2021
pouleyKetchoupp
approved these changes
Jan 29, 2021
|
Thanks! |
This was referenced Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally part of #21922, however that PR is taking forever to be reviewed, so I took the physics parts of it and put it into this PR. @AndreaCatania has already given #21922 an approval, so hopefully this PR won't take too long to get in (of course, more eyes are welcome, so I've requested a review from the entire Physics team).