Prevent selecting hidden nodes in Canvas Item Editor #46261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilfazer
force-pushed
the
fix_canvas_item_editor_select_hidden_nodes
branch
from
13c4fab
to
95073be
Compare
hilfazer
force-pushed
the
fix_canvas_item_editor_select_hidden_nodes
branch
from
95073be
to
28fa0f5
Compare
This was referenced Feb 21, 2021
akien-mga
approved these changes
Feb 21, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to select hidden nodes in Canvas Item Editor when nested scene instantiation was involved.
Similar to #46032.
The function get_deepest_visible_node() got renamed to get_deepest_editable_node() and moved to Node.cpp. 'visible' can be confused with a different concept.
It turned out my first impression was incorrect and those issues also appear in Godot 4.0. I'll try to make a PR for master branch as well.
Edit:
I made a project for testing:
https://github.com/hilfazer/Projects/tree/EngineIssues/Godot/EngineIssues/SelectingHiddenNodesIn3DandCanvasEditors_godot32
Download link: https://downgit.github.io/#/home?url=https://github.com/hilfazer/Projects/tree/EngineIssues/Godot/EngineIssues/SelectingHiddenNodesIn3DandCanvasEditors_godot32