Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML5] Add PWA support to the editor page. #46796

Merged
merged 2 commits into from
Mar 8, 2021
Merged

[HTML5] Add PWA support to the editor page. #46796

merged 2 commits into from
Mar 8, 2021

Commits on Mar 8, 2021

  1. [HTML5] Catch audio worklet errors on disconnect. 

    Which could happen if the worklet was not fully loaded, or the audio
context had already aborted.
    @Faless
    Faless committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    0816011 View commit details
    Browse the repository at this point in the history

  2. [HTML5] Add PWA support to the editor page. 

    This allows to install it as an app, and provide offline support (after
the first run).
Practically, this boils down to adding a JSON file as a manifest, an
offline page to be displayed when the cached files are not avaialble,
and a JS file to cache resources and return them.

The reason for the "first run requirements" is that some browsers, will
emit an "install" by just visiting the page (to see if the JS code is
compatibile), and we do not want to force casual visitors to just
download the 10 MiB+ compressed editor WebAssembly file without pressing
the start button.

Special thanks to Hugo Locurcio (Calinou) for the initial work.
    @Faless
    Faless committed Mar 8, 2021
    Configuration menu
    Copy the full SHA
    d8bd54f View commit details
    Browse the repository at this point in the history