Remove now unnecessary ResourceImporterCSV importer #47301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its only purpose was to prevent importing CSV files as translations, but it would still import them as *nothing*, leading to workflow issues. This is now properly fixed with godotengine#47268 which allows disabling the import for specific files.
akien-mga
added
enhancement
topic:import
cherrypick:3.x
fire
approved these changes
Mar 23, 2021
|
Cherry-picked for 3.3. |
akien-mga
removed
the
cherrypick:3.x
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its only purpose was to prevent importing CSV files as translations, but it
would still import them as nothing, leading to workflow issues.
This is now properly fixed with #47268 which allows disabling the import for
specific files.