Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shape_idx to CollisionObject2D mouse_entered signal #47395

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Add shape_idx to CollisionObject2D mouse_entered signal #47395

merged 1 commit into from
Jul 16, 2021

Conversation

sygi
Copy link
Contributor

@sygi sygi commented Mar 26, 2021

See proposal for discussion

@sygi sygi mentioned this pull request Mar 26, 2021
Closed
@sygi sygi force-pushed the shape_idx_collision branch 2 times, most recently from 76249d6 to 2a11c2f Compare March 26, 2021 17:54
@pouleyKetchoupp pouleyKetchoupp added this to the 4.0 milestone Mar 26, 2021
@pouleyKetchoupp pouleyKetchoupp requested a review from a team March 26, 2021 18:09
@sygi sygi force-pushed the shape_idx_collision branch 7 times, most recently from 04336ba to 671233c Compare March 28, 2021 10:54
@sygi sygi marked this pull request as ready for review April 6, 2021 19:36
@sygi sygi requested review from a team as code owners April 6, 2021 19:36
Calinou
Calinou requested changes Jun 11, 2021
View reviewed changes
doc/classes/CollisionObject2D.xml Outdated Show resolved Hide resolved
doc/classes/CollisionObject2D.xml Outdated Show resolved Hide resolved
doc/classes/CollisionObject2D.xml Outdated Show resolved Hide resolved
scene/main/viewport.cpp Outdated Show resolved Hide resolved
pouleyKetchoupp
pouleyKetchoupp suggested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@pouleyKetchoupp pouleyKetchoupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! It seems to works fine, and I don't have much to comment about the code except for the suggestion related to your TODO message.

scene/main/viewport.cpp Outdated Show resolved Hide resolved
@sygi sygi force-pushed the shape_idx_collision branch 3 times, most recently from dfd45f3 to 5c4e5bc Compare June 20, 2021 10:56
@sygi sygi requested review from pouleyKetchoupp and removed request for a team June 20, 2021 11:31
@pouleyKetchoupp
Copy link
Contributor

Great job, thank you!

@sygi sygi requested a review from Calinou June 26, 2021 18:56
Calinou
Calinou requested changes Jul 2, 2021
View reviewed changes
doc/classes/CollisionObject2D.xml Outdated Show resolved Hide resolved
doc/classes/CollisionObject2D.xml Outdated Show resolved Hide resolved
doc/classes/CollisionObject2D.xml Outdated Show resolved Hide resolved
doc/classes/CollisionObject2D.xml Outdated Show resolved Hide resolved
@sygi sygi requested a review from Calinou July 2, 2021 19:51
Calinou
Calinou approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 523d6b2 into godotengine:master Jul 16, 2021
@Calinou
Copy link
Member

Calinou commented Jul 16, 2021 •
edited
Loading

Feel free to open a 3.x pull request for this if it can be done in a backwards-compatible way 🙂

@sygi
Copy link
Contributor Author

sygi commented Jul 16, 2021

I don't think I'll be up for it -- looking forward for a transition to a stable 4.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper left review comments

@Calinou Calinou Calinou approved these changes

@pouleyKetchoupp pouleyKetchoupp pouleyKetchoupp approved these changes

Assignees
No one assigned
Labels
enhancement topic:physics topic:2d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sygi @pouleyKetchoupp @Calinou @RandomShaper