Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ensure_correct_normals working on GLES2 #47540

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Make ensure_correct_normals working on GLES2 #47540

merged 1 commit into from
Apr 14, 2021

Conversation

volzhs
Copy link
Contributor

@volzhs volzhs commented Apr 1, 2021

Fix #47536
image

@volzhs volzhs added this to the 3.3 milestone Apr 1, 2021
@volzhs volzhs requested a review from clayjohn April 1, 2021 07:38
@volzhs volzhs requested a review from a team as a code owner April 1, 2021 07:38
@volzhs volzhs marked this pull request as draft April 1, 2021 09:11
@volzhs
Copy link
Contributor Author

volzhs commented Apr 1, 2021 •
edited
Loading

I found that vertex lighting with ensure correct normals makes unexpected light strength changes on both GLES2 & 3. 😢

GLES3

gles3

GLES2

gles2

have no clue.
it seems another issue but... can't confirm.

anyone makes a PR supersedes this, I will be happy to close this.

@volzhs
Copy link
Contributor Author

volzhs commented Apr 1, 2021

I think vertex lighting issue is another thing.
vertex lighting
I had pretty good result with ensure correct normals on gles2 without vertex lighting, even on mobile.

@volzhs volzhs marked this pull request as ready for review April 1, 2021 10:35
JFonS
JFonS approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@JFonS JFonS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit 81f8b40 into godotengine:3.x Apr 14, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Apr 14, 2021
Closed
@volzhs volzhs deleted the ensure-normal-gles2 branch April 14, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFonS JFonS JFonS approved these changes

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@volzhs @akien-mga @JFonS