-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main: Default --doctool
path to '.' if none given
#47647
Conversation
261be99
to
75f5c3f
Compare
--doctool
path to '.' if none given
Note that this doesn't try to be overly clever so if you run Edit: Or actually no, with
So seems fine. |
main/main.cpp
Outdated
for (int j = i + 2; j < args.size(); j++) { | ||
removal_docs.push_back(args[j]); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unused. No clue what it was supposed to do.
Otherwise it works as expected on Windows for me and I see no regressions if I want it to output somewhere else. |
75f5c3f
to
096ef0d
Compare
for (int j = i + 2; j < args.size(); j++) { | ||
removal_docs.push_back(args[j]); | ||
doc_tool_path = args[i + 1]; | ||
if (doc_tool_path.begins_with("-")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the reference, this is something that could be done further up after else if (i < (args.size() - 1)) {
for all "paired" parameters, but it's more risky so I'm keeping it localized.
The proper fix anyway is to scrap all this and redo the argument parsing with a proper parser (#44594).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what --no-docbase
is supposed to do exactly, but it did something at least. So yeah, it works on Windows as expected.
Cherry-picked for 3.4. |
Many users miss the
.
part of the documentation that indicatesgodot --doctool .
as the usage, so let's make it the default (as it used to be years ago).