[HTML5] Export as Progressive Web App #48159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
force-pushed
the
js/4.x_pwa_export
branch
from
48187fb
to
41d6ea4
Compare
akien-mga
reviewed
Apr 27, 2021
Adds possibility to export as a progressive web app. Allows customizing base icons, display mode, orientation and offline page.
Faless
force-pushed
the
js/4.x_pwa_export
branch
from
41d6ea4
to
88c060b
Compare
akien-mga
approved these changes
Apr 27, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds possibility to export as a progressive web app.
Allows customizing base icons, display mode, orientation and offline page.
Which exports the the relevant required files and configures the service worker to cache them (images are generated from the project icon if not specified):
Resulting in a correctly installable PWA (tested on Chromium Linux, Chrome Android)
The resulting PWA works offline on desktop,
but it doesn't seem to work Android. I'll be doing some more research.it also work on Android, but only once deployed to a real address, not from the debug server.Based on both #47974 and #47386 .
A
3.xbackport is available here: https://github.com/Faless/godot/tree/js/3.x_pwa_on_backportBugsquad edit: This closes godotengine/godot-proposals#1269.