Remove uses of auto for better readability and online code reviews
#48185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
codestyle-no-auto
branch
from
f8677df
to
5ac464e
Compare
neikeq
suggested changes
Apr 25, 2021
|
I agree with the change as it's our code style, but more readable? I think not. |
akien-mga
reviewed
Apr 25, 2021
Calinou
force-pushed
the
codestyle-no-auto
branch
from
5ac464e
to
19db36f
Compare
aaronfranke
reviewed
Apr 25, 2021
Calinou
force-pushed
the
codestyle-no-auto
branch
from
19db36f
to
6625a1f
Compare
neikeq
suggested changes
Apr 26, 2021
The current code style guidelines forbid the use of `auto`. Some uses of `auto` are still present, such as in UWP code (which can't be currently tested) and macros (where removing `auto` isn't easy).
Calinou
force-pushed
the
codestyle-no-auto
branch
from
6625a1f
to
5d124c4
Compare
neikeq
approved these changes
Apr 26, 2021
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code style guidelines forbid the use of
auto.Some uses of
autoare still present, such as in UWP code (which can't be currently tested) and macros (where removingautoisn't easy).There are further code style changes that need to be made (there are some camelCase variables), but these changes should be made separately.
Note: The use of
autois not up for debate here – it's already been discussed at length 🙂