Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the focus outline translucent for editor viewports #48567

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 8, 2021

This makes the focus outline less distracting on the 2D and 3D editor viewports. We still need to keep this outline visible as it's the only way the user can see if their key presses will go to the viewport (for actions like Focus Selection). Originally requested on Twitter.

Note: Not cherry-pickable to the 3.x branch as this only pertains to the new editor theme.

Preview

Note: These screenshots are taken at the smallest possible window size. Remember that the focus outline becomes less distracting at larger screen sizes, since it takes up a lower portion of the window.

Before

Before

After

After

@Calinou Calinou requested a review from a team as a code owner May 8, 2021 23:57
@Calinou Calinou added this to the 4.0 milestone May 8, 2021
@samdze
Copy link
Contributor

samdze commented May 9, 2021

I prefer the non-translucent version for color consistency reasons, but not a big deal.
The "distracting" issue here is magnified due to the very small editor window in the preview.

@sairam4123
Copy link

Make sure it's possible to change Translucency in the editor settings.

@Calinou
Copy link
Member Author

Calinou commented Jun 21, 2021

Make sure it's possible to change Translucency in the editor settings.

I wouldn't add a setting for this as it's too niche. Instead, we should focus on picking a good default value, and the new default seems to be good enough.

@sairam4123
Copy link

Make sure it's possible to change Translucency in the editor settings.

I wouldn't add a setting for this as it's too niche. Instead, we should focus on picking a good default value, and the new default seems to be good enough.

Well, I liked the old opaque one, we could possibly range the setting between 0.25 and 1.

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in combination with #35891 and it looks great to me! This should be merged before #35891.

I'm tempted to suggest that this should just apply to all instances of the focus outline, but I'm not sure.

@akien-mga
Copy link
Member

Needs a rebase.

This makes the focus outline less distracting on the
2D and 3D editor viewports.
@Calinou
Copy link
Member Author

Calinou commented Jul 30, 2021

Rebased and tested again, it works as expected.

@Calinou Calinou force-pushed the editor-theme-less-opaque-viewport-focus branch from 54cee28 to e92297c Compare July 30, 2021 12:37
@akien-mga akien-mga merged commit ba274a6 into godotengine:master Jul 30, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-theme-less-opaque-viewport-focus branch December 8, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants