-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the focus outline translucent for editor viewports #48567
Make the focus outline translucent for editor viewports #48567
Conversation
I prefer the non-translucent version for color consistency reasons, but not a big deal. |
Make sure it's possible to change Translucency in the editor settings. |
I wouldn't add a setting for this as it's too niche. Instead, we should focus on picking a good default value, and the new default seems to be good enough. |
Well, I liked the old opaque one, we could possibly range the setting between 0.25 and 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase. |
This makes the focus outline less distracting on the 2D and 3D editor viewports.
Rebased and tested again, it works as expected. |
54cee28
to
e92297c
Compare
Thanks! |
This makes the focus outline less distracting on the 2D and 3D editor viewports. We still need to keep this outline visible as it's the only way the user can see if their key presses will go to the viewport (for actions like Focus Selection). Originally requested on Twitter.
Note: Not cherry-pickable to the
3.x
branch as this only pertains to the new editor theme.Preview
Note: These screenshots are taken at the smallest possible window size. Remember that the focus outline becomes less distracting at larger screen sizes, since it takes up a lower portion of the window.
Before
After