Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 2D particles to collide against SDF #48894

Merged
merged 1 commit into from
May 24, 2021

Conversation

reduz
Copy link
Member

@reduz reduz commented May 20, 2021

  • Added SDF collision support for 2D particles
  • Changed the SDF generation to be fully signed
trails_collision.mp4

@reduz reduz requested review from a team as code owners May 20, 2021 14:29
@Calinou Calinou added this to the 4.0 milestone May 20, 2021
@reduz reduz requested a review from a team as a code owner May 20, 2021 17:16
@reduz reduz force-pushed the gpu-particles-2d-2 branch 4 times, most recently from 88da506 to f415318 Compare May 20, 2021 19:30
@reduz
Copy link
Member Author

reduz commented May 21, 2021

@akien-mga Most of the bindings in RenderingServer are broken, will fix at a later time when the API stabilizes (its on my todo), so I am not bothering updating those for now.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some API suggestions, but otherwise seems good.

-Added SDF collision support for 2D particles
-Changed the SDF generation to be fully signed
@akien-mga akien-mga merged commit 9cf1d03 into godotengine:master May 24, 2021
@akien-mga
Copy link
Member

Thanks!

@LakshayaG73
Copy link

Hi. Any idea when this will be exposed? We cannot use 2D collisions in the godot 4 beta.

@clayjohn
Copy link
Member

@LakshayaG73 2D collisions were exposed in this PR, you can already use them. I have tested and confirmed they are working fine in Beta 2
Screenshot from 2022-10-15 09-54-43

@LakshayaG73
Copy link

@clayjohn can you elaborate a bit on how to use them?

@erniel
Copy link

erniel commented Dec 6, 2022

when will this be available to beta? its still not working on godot 4 beta 7

@Calinou
Copy link
Member

Calinou commented Dec 6, 2022

when will this be available to beta? its still not working on godot 4 beta 7

To generate a SDF for particle collision or custom shaders, you need to create LightOccluder2D nodes and ensure its Generate SDF property is enabled (it's enabled by default).

Edit: I've tried following that process, but collision never occurs: test_gpuparticles2d_collision.zip

stuartcarnie added a commit to stuartcarnie/godot that referenced this pull request Jun 20, 2024
fire pushed a commit to V-Sekai/godot that referenced this pull request Jul 2, 2024
MewPurPur pushed a commit to MewPurPur/godot that referenced this pull request Jul 11, 2024
sorascode pushed a commit to sorascode/godot-soras-version that referenced this pull request Jul 22, 2024
Luis-Wong pushed a commit to Luis-Wong/godot that referenced this pull request Jul 26, 2024
2nafish117 pushed a commit to 2nafish117/godot that referenced this pull request Aug 5, 2024
chryan pushed a commit to chryan/godot that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants