BVH - fix stale current_tree in deactivate function #49057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in deactivate where current_tree variable was stale. This may have resulted in visual anomalies.
Changes passing of current_tree from a member variable to a function argument, making bugs due to stale state less likely.
May fix #48749
May fix #48790
Notes
current_tree
totree_id
, as that name seems to make more sense when passing it as an argument rather than using it as a state.