Use real_t in editor plugins #49783
Merged
Use real_t in editor plugins #49783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Jun 24, 2021
KoBeWi
reviewed
Jun 24, 2021
KoBeWi
approved these changes
Jun 24, 2021
aaronfranke
force-pushed
the
real-editor-plugins
branch
from
d066b29
to
66cbd21
Compare
aaronfranke
force-pushed
the
real-editor-plugins
branch
from
66cbd21
to
9a4baa2
Compare
aaronfranke
force-pushed
the
real-editor-plugins
branch
2 times, most recently
from
7115d78
to
97eb1ad
Compare
aaronfranke
force-pushed
the
real-editor-plugins
branch
2 times, most recently
from
74c0061
to
f6975ed
Compare
Also use const more often and delete dead code in CanvasItemEditor
aaronfranke
force-pushed
the
real-editor-plugins
branch
from
f6975ed
to
dbad475
Compare
akien-mga
approved these changes
Aug 2, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #21922, split into its own PR for easy reviewing.
This PR uses
real_twhere appropriate in editor plugins. It also fixes a few other things that I noticed while reviewing this code including fixing places where precision is needlessly lost, using const more often, and deleting dead code in CanvasItemEditor.