Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Net] Fix WebSocketClient path parsing. #49965

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Jun 28, 2021

Recent changes to parse_url (#48205) caused the client to make invalid HTTP requests if no path was specified.

Recent changes to parse_url caused the client to make invalid HTTP
requests if no path was specified.
@Faless Faless added bug topic:network regression cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.3 labels Jun 28, 2021
@Faless Faless added this to the 4.0 milestone Jun 28, 2021
@Faless Faless requested a review from akien-mga June 28, 2021 13:48
@Faless Faless requested a review from a team as a code owner June 28, 2021 13:48
@akien-mga akien-mga merged commit 51350a9 into godotengine:master Jun 28, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 29, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants