Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows Export] Use temporary file for osslsigncode signing. #49985

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 29, 2021

Fixes #49869

@bruvzg bruvzg added bug platform:windows cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.3 topic:export labels Jun 29, 2021
@bruvzg bruvzg added this to the 4.0 milestone Jun 29, 2021
@bruvzg bruvzg requested a review from a team as a code owner June 29, 2021 07:39
@akien-mga akien-mga merged commit 45b66e9 into godotengine:master Jun 29, 2021
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the win_sign_temp_file branch June 29, 2021 08:09
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jun 29, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code signing windows export fails on non-windows platform
2 participants