Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gridmap free octans #50049

Closed
wants to merge 1 commit into from
Closed

Fix gridmap free octans #50049

wants to merge 1 commit into from

Conversation

Valeryn4
Copy link
Contributor

@Valeryn4 Valeryn4 commented Jul 1, 2021

Fix GridMap problem issue

@Valeryn4 Valeryn4 requested a review from a team as a code owner July 1, 2021 12:48
@Calinou Calinou added bug topic:3d topic:core topic:physics cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release and removed topic:physics labels Jul 1, 2021
@Calinou Calinou added this to the 4.0 milestone Jul 1, 2021
@pouleyKetchoupp
Copy link
Contributor

Looks great! This fixes #33648, #43712 and #49995 which are all the same bug.

The only thing is a PR should be opened on master instead of 3.3 branch. It's the usual process for fixes that can be applied to the latest version of Godot (it will still be cherry-picked for 3.3 and 3.4).

I would suggest to close this PR and open the same one on master (switching branches causes issues with github, it's interpreted as trying to merge the whole branch).

@Calinou Calinou removed cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jul 1, 2021
@Calinou Calinou modified the milestones: 4.0, 3.3 Jul 1, 2021
@Valeryn4
Copy link
Contributor Author

Valeryn4 commented Jul 1, 2021

I would suggest to close this PR and open the same one on master (switching branches causes issues with github, it's interpreted as trying to merge the whole branch).

Sorry)
This error stopped my development progress)

@pouleyKetchoupp
Copy link
Contributor

No worries at all, your fix is very welcome!

Let me know in case it's too much extra work for you to set things up on master. Instead another contributor can open the new PR on master and credit you for your work.

@Valeryn4
Copy link
Contributor Author

Valeryn4 commented Jul 1, 2021

Pull PR : #50052

@Valeryn4 Valeryn4 closed this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug topic:core topic:3d
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Valeryn4 @pouleyKetchoupp @Calinou