Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Improve the UI/UX of the Export Template Manager dialog #50531

Merged

Conversation

YuriSizov
Copy link
Contributor

@YuriSizov YuriSizov commented Jul 16, 2021

Backport of #48902. After this is merged, #35868 can be tested again.

There is some small glitch when you close the window while downloading and reopen it. For a split second an error shows up, but is quickly replaced by the status update. Not sure what's up with that, but it's probably not directly related to this PR. Either way, it's not really disruptive and goes away momentarily.

@YuriSizov YuriSizov added this to the 3.4 milestone Jul 16, 2021
@YuriSizov YuriSizov requested a review from a team July 16, 2021 21:49
@YuriSizov YuriSizov changed the title Improve the UI/UX of the Export Template Manager dialog [3.x] Improve the UI/UX of the Export Template Manager dialog Jul 16, 2021
@AaronRecord
Copy link
Contributor

AaronRecord commented Jul 17, 2021

When I run it I get the following popup error "Error getting the list of mirrors.". I'm guessing this is just because it's not an official build? It makes it annoying to test though, as it won't let me "Download and Install". Is there a workaround?

@Calinou
Copy link
Member

Calinou commented Jul 17, 2021

Is there a workaround?

You can edit version.py to make your Godot build pretend it's from another version, then recompile the editor.

That said, we should probably disable the download button and set a tooltip when using a development build (dev status) or non-numbered alpha/beta/RC build. There will never be official export templates available for those, as official export templates are only available for stable releases and numbered alpha/beta/RC builds.

@YuriSizov
Copy link
Contributor Author

@Calinou The button is disabled and there is such tooltip already 👀

@akien-mga akien-mga merged commit 7fe45cb into godotengine:3.x Jul 20, 2021
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the editor-improve-template-downloader-3.x branch July 20, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants